Replace local Wire codegen with org.meshtastic:protobufs SDK#50
Draft
jamesarich wants to merge 1 commit into
Draft
Replace local Wire codegen with org.meshtastic:protobufs SDK#50jamesarich wants to merge 1 commit into
jamesarich wants to merge 1 commit into
Conversation
… SDK Replace the protobufs git submodule and local Wire code generation in the sample app with the published org.meshtastic:protobufs:2.7.25-SNAPSHOT SDK. Changes: - Remove protobufs git submodule and .gitmodules - Remove Wire Gradle plugin from root and sample build scripts - Add org.meshtastic:protobufs dependency to sample/commonMain - Add Sonatype snapshots repository for SNAPSHOT resolution - Remove wasmJs target from sample (SDK does not publish wasmJs yet) - Fix smart cast issue with MeshPacket.encrypted from external module - Remove wire-runtime and wire plugin from version catalog Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Draft
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample app currently vendors the
protobufsgit submodule and runs the Wire Gradle plugin at build time to generate Kotlin models locally. The meshtastic/protobufs repo now publishes a pre-built KMP artifact (org.meshtastic:protobufs) to Maven Central, so consumers no longer need local codegen -- they can depend on the published SDK directly. This aligns MQTTastic-Client-KMP with the same migration done in Meshtastic-Android (meshtastic/Meshtastic-Android#5675) and TAKPacket-SDK (meshtastic/TAKPacket-SDK#42).Approach
protobufsgit submodule and.gitmodulesentirelyorg.meshtastic:protobufs:2.7.25-SNAPSHOTas a dependency in the sample'scommonMainsettings.gradle.ktsfor SNAPSHOT resolutionwire-runtimelibrary andwireplugin entries from the version catalogNotable trade-offs
librarymodule (the MQTT client itself) is unaffected and still supports wasmJs.2.7.25-SNAPSHOTuntil a stable release is cut from the protobufs repo. Once published to Maven Central proper, update to the release version.MeshPacket.encryptedis now a public property from an external module, so Kotlin can no longer smart-cast it. Wrapped in.let {}to resolve.